Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full type name for Lucene lock type #14805

Merged
merged 7 commits into from
Dec 19, 2023
Merged

Add full type name for Lucene lock type #14805

merged 7 commits into from
Dec 19, 2023

Conversation

DrewScoggins
Copy link
Contributor

In net9.0 the runtime now exposes it's own Lock type, dotnet/runtime#87672. This causes a build break as there is a collision between the Lucene type and the runtime type.

@DrewScoggins
Add full type name for Lucene lock type
bcf286b 
In net9.0 the runtime now exposes it's own `Lock` type, dotnet/runtime#87672. This causes
a build break as there is a collision between the Lucene type and the
runtime type.
@hishamco hishamco requested a review from Skrypt December 1, 2023 22:14
@DrewScoggins
Copy link
Contributor Author

I added an alias for Lucene.Net.Store because that was colliding with OrchardCore.Search.Lucene. I am happy to do it another way if there is a better one, but this was what I came up with.

@DrewScoggins
Copy link
Contributor Author

Does this change look good?

@hishamco
Copy link
Member

hishamco commented Dec 4, 2023

I think the change should be in lock only

@DrewScoggins
Copy link
Contributor Author

If the change is limited to just the one that you requested you can't build the project and get this error

D:\git\OrchardCore\src\OrchardCore.Modules\OrchardCore.Search.Lucene\Services\LuceneIndexManager.cs(398,48): error CS02
34: The type or namespace name 'Net' does not exist in the namespace 'OrchardCore.Search.Lucene' (are you missing an as
sembly reference?) [D:\git\OrchardCore\src\OrchardCore.Modules\OrchardCore.Search.Lucene\OrchardCore.Search.Lucene.cspr
oj::TargetFramework=net8.0]

This is why I made the change to add the alias for the Lucene.Net.Store namespace. If there is a better way to solve that issue I am happy to use that, but this is the only way that I know.

sebastienros and others added 5 commits December 19, 2023 11:38
@sebastienros @hishamco
Update src/OrchardCore.Modules/OrchardCore.Search.Lucene/Services/Luc…
0fefe27 
…eneIndexManager.cs

Co-authored-by: Hisham Bin Ateya <[email protected]>
@sebastienros @hishamco
Update src/OrchardCore.Modules/OrchardCore.Search.Lucene/Services/Luc…
0f04aab 
…eneIndexManager.cs

Co-authored-by: Hisham Bin Ateya <[email protected]>
@sebastienros @hishamco
Update src/OrchardCore.Modules/OrchardCore.Search.Lucene/Services/Luc…
3b9102d 
…eneIndexManager.cs

Co-authored-by: Hisham Bin Ateya <[email protected]>
@sebastienros @hishamco
Update src/OrchardCore.Modules/OrchardCore.Search.Lucene/Services/Luc…
bba7075 
…eneIndexManager.cs

Co-authored-by: Hisham Bin Ateya <[email protected]>
@sebastienros @hishamco
Update src/OrchardCore.Modules/OrchardCore.Search.Lucene/Services/Luc…
e83982d 
…eneIndexManager.cs

Co-authored-by: Hisham Bin Ateya <[email protected]>
@sebastienros sebastienros merged commit 75e9e7a into OrchardCMS:main Dec 19, 2023
3 checks passed
@github-actions github-actions bot mentioned this pull request Jan 11, 2024
Closed
urbanit pushed a commit to urbanit/OrchardCore that referenced this pull request Mar 18, 2024
@DrewScoggins @urbanit
Add full type name for Lucene lock type (OrchardCMS#14805)
8d141c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishamco hishamco hishamco requested changes

@Skrypt Skrypt Awaiting requested review from Skrypt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DrewScoggins @hishamco @sebastienros